Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corpus tests #25

Open
resolritter opened this issue Apr 7, 2023 · 2 comments
Open

Add corpus tests #25

resolritter opened this issue Apr 7, 2023 · 2 comments

Comments

@resolritter
Copy link
Collaborator

tree-sitter grammars usually have corpus tests in a test/corpus folder, for example https://github.com/tree-sitter/tree-sitter-javascript/tree/5720b249490b3c17245ba772f6be4a43edb4e3b7/test/corpus. Those tests can be run by using tree-sitter test. They are useful for detecting existing problems, preventing bugs from future grammar changes and catching software regressions.

Are you going to add them? If not, are you willing to accept to a PR for that?

@resolritter
Copy link
Collaborator Author

It'd be good to have the tests on CI once they're implemented. Let me know if you need help with that.

@maxxnino
Copy link
Owner

maxxnino commented Apr 7, 2023

I only use them from my local machine. Add quick header to each file. and a small python script to grab ERROR in those files. Sometime I use, sometime I don't. Write test really time consuming, and I don't know anything about CI. If you want to do it. I'm happy to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants