Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not start transmission if there were errors in URI #25

Open
1 of 2 tasks
maxsharabayko opened this issue Nov 4, 2020 · 0 comments
Open
1 of 2 tasks

Do not start transmission if there were errors in URI #25

maxsharabayko opened this issue Nov 4, 2020 · 0 comments
Assignees

Comments

@maxsharabayko
Copy link
Owner

maxsharabayko commented Nov 4, 2020

As of srt-xtransmit checks if a correct URI query was provided, but only reports a warning.
Instead, it is better to report an error and do not start data transmission, because the user may miss the warning, especially if ran from some scripts that suppress std error.

Current behavior when rexmit_algo=1 is given instead of retransmitalgo=1:

./bin/srt-xtransmit generate "srt://:4200?rexmit_algo=1"
18:06:15.779625 [W] SOCKET::SRT srt://:4200: Ignoring socket option 'rexmit_algo=1' (not recognized)!

TODO

  • generate and receive subcommands report an error. PR Throw exception on invalid URI query #27.

  • route "srt://:4200?modest=caller" srt://4201 -v tries to connect destination first, then check source and report an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant