Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

It caused the very obvious lagging if the reducer store is large #33

Closed
xingsuo opened this issue Nov 14, 2018 · 5 comments
Closed

It caused the very obvious lagging if the reducer store is large #33

xingsuo opened this issue Nov 14, 2018 · 5 comments

Comments

@xingsuo
Copy link

xingsuo commented Nov 14, 2018

I am working on the performance issue for two weeks but end up found that this encryption is quite time consuming and will block the UI if the data is very large

@maxdeviant
Copy link
Owner

@xingsuo Yea, unfortunately encryption/decryption can be quite slow.

Ideally you would need to do the encryption/decryption asynchronously in order to not block the UI thread, but right now async support isn't working.

Part of the problem is that (at least when it was implemented), redux-persist didn't support a Promise-based API to allow for asynchronous encryption/decryption. I have not looked to see if that situation has changed at all.

@xingsuo
Copy link
Author

xingsuo commented Nov 14, 2018

@maxdeviant Thanks for the quick response and explanation. I am wondering if there is a way to control the timing of the encryption/decryption? Because I am thinking if it's possible I can just put it while the UI is free, such as onLoading or onClose of the app.

@JeremyBradshaw7
Copy link

When do you notice the lagging? Just on app start (dehydrate) or when every redux reducer runs?

@maxdeviant
Copy link
Owner

I don't think we have any recourse here until #48 is resolved.

@maxdeviant
Copy link
Owner

Closing this issue since there isn't anything that can be done in the current state of things.

@maxdeviant maxdeviant closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants