Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help improve logging performance. Debug logging #7

Open
gatling822 opened this issue Jan 18, 2018 · 2 comments · May be fixed by #10
Open

Help improve logging performance. Debug logging #7

gatling822 opened this issue Jan 18, 2018 · 2 comments · May be fixed by #10

Comments

@gatling822
Copy link

`if (log.isLoggable(Level.INFO)) {

  log.info("matched: " + msg);

}

if (log.isLoggable(Level.INFO)) {

  log.info("unmatched: " + msg);

}`

The above log statements could be changed to DEBUG. In my system where there are 100+ rules run against 10,000+ transactions per minute. This log statement quickly takes over all the logs. If you change this log to DEBUG we would be able to keep helpful information like what rules are loaded but the information for which rules are matched is more of a DEBUG information for when we encountered an issue
@maxant
Copy link
Owner

maxant commented Jan 24, 2018

In the mean time, you can set the log level of the rules engine to be a different level than that of the rest of the application. Or set default to be WARN and set your packages to be INFO.

@maxant
Copy link
Owner

maxant commented Jan 24, 2018

btw, we happily accept pull requests

@gatling822 gatling822 linked a pull request Feb 16, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update logging Level and allow Sub Classing gatling822/rules
2 participants
@maxant @gatling822