This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
Prevent error when two BrowserWindow events collide; Reduce window flashing #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't know if my code or module, but either way it seems to fix the problem
bigfarofa
changed the title
bigfarofa
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use the Microsoft(azure/graph) oAuth, the BrowserWindow would trigger the two events, leading to the module trying to close the Window twice causing an error.
Again with Microsoft oAuth, you have a option to remember the user, if the user wants to have always the session already signed in. The BrowserWindow would open for just 2 seconds and then close(Window Flashing).