Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple optimistic reducers: only react to your own actions #55

Open
Buggytheclown opened this issue Apr 4, 2021 · 0 comments
Open

Comments

@Buggytheclown
Copy link

Buggytheclown commented Apr 4, 2021

Feature request, i think it's important because:

  • optimization - we can skip some work
  • DX improvements - easy to debug optimistic slice, history have only valuable for the slice actions

I want to use multiple optimistic slices:

  • module isolation, code splitting: each module should work as isolated feature, we should be able to add it via 'lazy route' + 'replaceReducer'
  • optimization: don't want to store all actions (if we already have any BEGIN action), some payload may be to heavy

For example, if i use multiple 'optimistic' slices, i want each 'optimistic' enhancer react only on own actions:

const enhancedRootReducerNested = combineReducers({
  counter1: optimistic(counterReducer1), // 'INC_1'
  counter2: optimistic(counterReducer2), // 'INC_2'
})

test('only react on own BEGIN', t => {
  const begin0 = makeAction('INC_2', BEGIN, 0);
  const state1 = enhancedRootReducerNested(undefined, begin0);

  const expected = {
    counter1: {
      beforeState: undefined,
      history: [],
      current: 0
    },
    counter2: {
      beforeState: 0,
      history: [begin0],
      current: 1
    },
  };
  t.deepEqual(state1, expected);
});

Can be related with #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant