Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make a http driver for unsupported services that provide restful api #3

Open
r8928 opened this issue Nov 4, 2020 · 1 comment

Comments

@r8928
Copy link

r8928 commented Nov 4, 2020

No description provided.

@matthewbdaly
Copy link
Owner

I'm not quite sure what you're getting at. A generic HTTP driver wouldn't be all that practical.

If you want the ability to extend this package with custom drivers without having to add them to sms-client, that might be doable.

Laravel already has several manager classes like the storage and cache managers which can be extended with custom drivers, and we could potentially add a manager class to this package that would allow for that, and have the driver be resolved separately from the client by that. You could then call something like SMSManager::extends('foo') and pass in a callable that creates the new driver, much as you do for custom filesystems.

Would that do what you want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants