Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heuristic to enable --slow for ZK chains #689

Open
Karrq opened this issue Nov 1, 2024 · 0 comments
Open

Add heuristic to enable --slow for ZK chains #689

Karrq opened this issue Nov 1, 2024 · 0 comments
Labels
good first issue 🐣 Good for newcomers needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item upstream-parity 🟰 Needed for upstream feature parity

Comments

@Karrq
Copy link
Contributor

Karrq commented Nov 1, 2024

The only way to run it without --slow would be to use a chain id that is detected as not having batching support, but that's a rather limited list, and not really a solution imo.
We may consider improving this in the future but right now there's no such work being done

Originally posted by @Karrq in #680


ZK chains do not support batching, therefore scripts which have transactions that depend on each other will fail when broadcasted (as simulation is always sequential).
Perhaps there's another way to detect if a chain is ZK or not (similar to how we do for fork perhaps?) and use that information to enable sequential broadcasting

@Karrq Karrq added good first issue 🐣 Good for newcomers needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item upstream-parity 🟰 Needed for upstream feature parity labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🐣 Good for newcomers needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item upstream-parity 🟰 Needed for upstream feature parity
Projects
None yet
Development

No branches or pull requests

1 participant