Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline forge create #662

Open
Karrq opened this issue Oct 28, 2024 · 0 comments
Open

Streamline forge create #662

Karrq opened this issue Oct 28, 2024 · 0 comments
Labels
good first issue 🐣 Good for newcomers needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item

Comments

@Karrq
Copy link
Contributor

Karrq commented Oct 28, 2024

During one of the foundry upstream update, we ended up duplicating a bunch of logic to be zksync-specific.

Refactoring it to be more "streamlined" would be a nice improvement, it would basically entail removing this block so we get the contract either from solc or zksolc and process it the same way, similar to how we were doing before
@Karrq Karrq added good first issue 🐣 Good for newcomers p3 🔵 Indicates low priority item needs triage ♟️ Issue needs to be picked up or assigned labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🐣 Good for newcomers needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Karrq