Feature: Pending transactions #56

TonioMacaronio · 2018-10-25T23:41:03Z

Current behavior:
Now you can only get past transactions and show them

Expected behavior:
Needs to get pending transactions and show them

Solution:
You can use txpool, made by @currybab in his PR
For Franklin use Matter Plasma Ignis API to get pending transactions.

The text was updated successfully, but these errors were encountered:

gitcoinbot · 2019-03-18T16:57:51Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$45,803.38 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot · 2019-03-18T17:07:34Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 week, 2 days ago.
Please review their action plans below:

1) santteegt has been approved to start work.

I´ll love to work on this as a first good issue for using a plasma impl.

Learn more on the Gitcoin Issue Details page.

TonioMacaronio · 2019-03-20T08:49:50Z

@santteegt hi! Great that you want to help with this. Ready to answer your questions

santteegt · 2019-03-20T14:28:38Z

Hi @BaldyAsh,

I've already setup the project dev environment. I was doing some tests by sending small Eth transactions on the Rinkeby testnet. Digging into the code, seems that this feature has to be implemented under the uploadTransactions() function in the TransactionHistory view controller. Now, I'm going to do some tests using the txPool instance available under wallet.web3Instance. In case I found some issues, I'll reach you :)

gitcoinbot · 2019-03-25T16:15:58Z

@santteegt Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

santteegt · 2019-03-25T23:50:06Z

Hi @BaldyAsh,

After doing some test trying to get the tx pool for sent ETH trxs on the Rinkeby testnet, I was always getting nil. Looking at the documentation seems that it does not work with Infura providers. Do I need to setup a local node to implement this, as mentioned in the reference PR?

gitcoinbot · 2019-03-31T16:15:24Z

@santteegt Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

TonioMacaronio · 2019-03-31T18:53:20Z

@santteegt you are right. Think I need to implement subscriptions in web3swift myself and then this issue can be solved

santteegt · 2019-04-01T03:46:02Z

Hi @BaldyAsh,

Okay, so should I wait until this feature is implemented under web3swift? I was thinking of implementing a manual tx pool by maintaining a sent tx list in global state and then verify if each of them was confirmed using the getTransactionReceipt method, but the downside is that this will be hardcoded in the wallet project.

On the other hand, in order to send transactions through the Plasma chain, how can I get some Franklin tokens?

TonioMacaronio · 2019-04-01T06:47:39Z

@santteegt think you may implement just UI and make some mocks for TXs loading. You can write mocks assuming that the pending TXs interface will be similar to the one that is in web3.js. I think this should be enough, I'll finish web3swift part and the task will be completed.
For plasma - there is no need for separated pending TXs loading, and besides I have not implemented TXs in Swift yet. There is used a curve for signing TXs, that is not yet implemented in Swift. So currently I'm working on bridging some rust libs functionality with iOS.

TonioMacaronio · 2019-04-01T21:06:11Z

@santteegt started work in web3swift-team/web3swift#144

gitcoinbot · 2019-04-06T16:15:24Z

@santteegt Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

santteegt · 2019-04-06T17:54:16Z

Hi @BaldyAsh ,

I was considering using the current UI features to show pending transactions (Bob trx on screen image) under the All tab

I was looking to your progress in the websockets feature and seems that you almost finish it. Let me know when this feature is fully available on web3swift :)

TonioMacaronio · 2019-04-06T19:29:14Z

@santteegt hi, yes I've almost finished. There was some pod issue, hope it will not appear in new release. Or I'll integrate web3swift in Franklin as framework and it will work.
Regarding pending txs - yes they should be presented in that way ;)

santteegt · 2019-04-10T03:29:40Z

Hi @BaldyAsh,

I just looked that you made a new release for the web3swift library. I've proceeded to update the web3swift pod version to 2.1.3 and also changed the Swift language to version 5, but I'm getting some compiling errors on the new code that implements the support for web sockets, such as Value of optional type '[String : Any]?' must be unwrapped to refer to member 'subscript' of wrapped base type '[String : Any]' at line 171 of Web3+InfuraProviders.swift:

let result = dictionary["result"] as? String {
        // setting filter id
       filterID = result
}

Not sure if I'm missing something when upgrading the pods.

TonioMacaronio · 2019-04-10T09:42:02Z

@santteegt hi, I've updated Franklin myself and haven't faced this error. Could you provide me a link to your project?

TonioMacaronio · 2019-04-11T14:10:23Z

@santteegt You can use updated Franklin version from this branch https://github.com/matter-labs/FranklinPay-iOS/tree/w3s2.1.3update

santteegt · 2019-04-11T16:51:14Z

Cool! Thanks @BaldyAsh. I'll use that branch

santteegt · 2019-04-14T06:45:46Z

Hi @BaldyAsh,

I am working in the following approach for fulfilling this feature. What do you think?

Store all sent transactions on the ETHTransactionModel with isPending=true.
When the TransactionHistory view refreshes:

fetch these records
compare txhashes with confirmed tx list
update the record status on those that were already confirmed
trxs that are still pending are appended to the view list

TonioMacaronio · 2019-04-14T18:00:37Z

@santteegt hi, think this should work, don't forget about failed txs :)

santteegt · 2019-04-17T05:42:39Z

Hi @BaldyAsh,

I just created a WIP PR for you to review my approach. It is working but sometimes while the pending transaction is confirmed through web3, the tx does not appear until Etherscan index that transaction a 1-2 seconds later.

gitcoinbot · 2019-04-21T16:15:29Z

@santteegt Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2019-04-21T21:18:58Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

@santteegt

@ceresstation please take a look at the submitted work:

PR by @santteegt

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$97,444.25 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot · 2019-04-26T22:05:42Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @santteegt.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$97,941.27 more funded OSS Work available on the Gitcoin Issue Explorer

skywinder assigned TonioMacaronio Oct 28, 2018

skywinder added the enhancement New feature or request label Oct 28, 2018

TonioMacaronio added help wanted Extra attention is needed good first issue Good for newcomers Gitcoin For Gitcoin bounties labels Feb 12, 2019

santteegt mentioned this issue Apr 17, 2019

Add pending transactions to TransactionHistory view #72

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Pending transactions #56

Feature: Pending transactions #56

TonioMacaronio commented Oct 25, 2018 •

edited

Loading

gitcoinbot commented Mar 18, 2019

gitcoinbot commented Mar 18, 2019 •

edited

Loading

TonioMacaronio commented Mar 20, 2019 •

edited

Loading

santteegt commented Mar 20, 2019

gitcoinbot commented Mar 25, 2019

santteegt commented Mar 25, 2019 •

edited

Loading

gitcoinbot commented Mar 31, 2019

TonioMacaronio commented Mar 31, 2019

santteegt commented Apr 1, 2019

TonioMacaronio commented Apr 1, 2019

TonioMacaronio commented Apr 1, 2019 •

edited

Loading

gitcoinbot commented Apr 6, 2019

santteegt commented Apr 6, 2019

TonioMacaronio commented Apr 6, 2019 •

edited

Loading

santteegt commented Apr 10, 2019

TonioMacaronio commented Apr 10, 2019

TonioMacaronio commented Apr 11, 2019 •

edited

Loading

santteegt commented Apr 11, 2019 •

edited

Loading

santteegt commented Apr 14, 2019

TonioMacaronio commented Apr 14, 2019

santteegt commented Apr 17, 2019

gitcoinbot commented Apr 21, 2019

gitcoinbot commented Apr 21, 2019

gitcoinbot commented Apr 26, 2019

Feature: Pending transactions #56

Feature: Pending transactions #56

Comments

TonioMacaronio commented Oct 25, 2018 • edited Loading

gitcoinbot commented Mar 18, 2019

gitcoinbot commented Mar 18, 2019 • edited Loading

TonioMacaronio commented Mar 20, 2019 • edited Loading

santteegt commented Mar 20, 2019

gitcoinbot commented Mar 25, 2019

santteegt commented Mar 25, 2019 • edited Loading

gitcoinbot commented Mar 31, 2019

TonioMacaronio commented Mar 31, 2019

santteegt commented Apr 1, 2019

TonioMacaronio commented Apr 1, 2019

TonioMacaronio commented Apr 1, 2019 • edited Loading

gitcoinbot commented Apr 6, 2019

santteegt commented Apr 6, 2019

TonioMacaronio commented Apr 6, 2019 • edited Loading

santteegt commented Apr 10, 2019

TonioMacaronio commented Apr 10, 2019

TonioMacaronio commented Apr 11, 2019 • edited Loading

santteegt commented Apr 11, 2019 • edited Loading

santteegt commented Apr 14, 2019

TonioMacaronio commented Apr 14, 2019

santteegt commented Apr 17, 2019

gitcoinbot commented Apr 21, 2019

gitcoinbot commented Apr 21, 2019

gitcoinbot commented Apr 26, 2019

TonioMacaronio commented Oct 25, 2018 •

edited

Loading

gitcoinbot commented Mar 18, 2019 •

edited

Loading

TonioMacaronio commented Mar 20, 2019 •

edited

Loading

santteegt commented Mar 25, 2019 •

edited

Loading

TonioMacaronio commented Apr 1, 2019 •

edited

Loading

TonioMacaronio commented Apr 6, 2019 •

edited

Loading

TonioMacaronio commented Apr 11, 2019 •

edited

Loading

santteegt commented Apr 11, 2019 •

edited

Loading