Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zoom for orthographic camera #1

Open
stuikomma opened this issue Jan 26, 2015 · 5 comments
Open

add zoom for orthographic camera #1

stuikomma opened this issue Jan 26, 2015 · 5 comments

Comments

@stuikomma
Copy link
Contributor

Works great so far. Only I'm missing proper support for cameras other than PerspectiveCamera.
E.g. zoom does not work with an OthographicCamera.

@mattdesl
Copy link
Owner

This seems like a limitation of ThreeJS' OrbitControls?

This module is mainly meant to mirror the ThreeJS examples. So the best course of action is to submit a PR to ThreeJS repo fixing the bug, and then let me know here and I'll bring in the new code.

@stuikomma
Copy link
Contributor Author

Sadly this is not at the top of our agenda (although definitely nice to have 😃). We'll see if we have time to add this and make the pull request.

@versipellis
Copy link

Did this ever go anywhere?

@stuikomma
Copy link
Contributor Author

I don't quite recall the issues, but actually there is code related to zooming with an OrthographicCamera
https://github.com/mattdesl/three-orbit-controls/blob/master/index.js#L35 and https://github.com/mattdesl/three-orbit-controls/blob/master/index.js#L372

@versipellis
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants