Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDF writer generates invalid files when values are too big #95

Open
mattbit opened this issue Nov 25, 2020 · 1 comment
Open

EDF writer generates invalid files when values are too big #95

mattbit opened this issue Nov 25, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@mattbit
Copy link
Owner

mattbit commented Nov 25, 2020

When writing to EDF a signal with very high values (e.g. 1e9), the file gets created successfully, but it is an invalid EDF. This happens because pyedflib doesn't take into account overflow of the fixed number of ascii bytes used to write the physical max and min.

Before generating this situation, the signal should be validated and an exception should be raised.

@mattbit mattbit added the bug Something isn't working label Nov 25, 2020
@mattbit
Copy link
Owner Author

mattbit commented Nov 25, 2020

We could also change the code to use the more modern highlevel interface of pyedflib, it would slightly simplify things and maybe also solve this problem (but I'm not sure about that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant