forked from trvrb/antigen
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
At the beginning of the simulation, make sure that viruses are initiated with the input sequence instead of a random sequence #23
Comments
zorian15
added a commit
that referenced
this issue
Jun 20, 2023
* Created a GeometricSeqPhenotype class that implements Phenotype and uses composition * Maintain translation from nucleotides to amino acids * Precompute vectors from gamma distribution * Made sure nucleotide is being mutated to a different letter. * Test matrix of vectors drawn from the gamma distribution * Remove gamma distribution csv output from repo * Keep mutating until it's not a stop codon * if mutation creates a stop codon, switch index to mutate * represent sequence using a char[] * use inheritance instead of composition * Clean up code, add documentation * finish unit tests for geometricseq * clean up repo * each sentence gets own line. * Address Hugh and Zorian's comments. First round. * Remove SequencePhenotype.java * Fix issue #23 * Remove DMS file requirement * Clean up code and refactor sanity check * Created a GeometricSeqPhenotype class that implements Phenotype and uses composition * Maintain translation from nucleotides to amino acids * Precompute vectors from gamma distribution * Made sure nucleotide is being mutated to a different letter. * Test matrix of vectors drawn from the gamma distribution * Remove gamma distribution csv output from repo * Keep mutating until it's not a stop codon * if mutation creates a stop codon, switch index to mutate * represent sequence using a char[] * use inheritance instead of composition * Clean up code, add documentation * finish unit tests for geometricseq * clean up repo * Address Hugh and Zorian's comments. First round. * Fix issue #23 * Remove DMS file requirement * Clean up code and refactor sanity check * format updates. * remove illegal characters from filename * update readme * Nonfunctional changes to code from Erick's review of PR #22 * Test CodonMap values are correct * Update out.tips for GeometricSeq fields * change names from traitA/B to ag1/2 to consistency * Clean up commented and unused code * print fasta for branches * Add startingSequence and epitopeSites files and output fasta file * Initial commit for testing geometric seq phenotype without predefined dictionary of vectors * Clean up and refactor things * Fix bug with reset and organize/optimize a little more in GeometricSeqPhenotype.java * Make sure that the nucleotide sequence is updated even for synonymous mutations * fasta file rename for pipeline * Update README.md * updates to params for customization of output path * remove .out from outputs * Add headers to fasta file sequences * Update to deme name instead of ID * allow last codon to be a stop * log file creation * file formatting --------- Co-authored-by: Zorian Thornton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think there is a bug in the way that we initialize the simulation. Specifically, when we initialize a virus object at the start of the simulation:
antigen/Parameters.java
Line 121 in 9add838
... we create a new GeometricSeqPhenotype object without providing an input sequence:
antigen/PhenotypeFactory.java
Line 19 in 9add838
The result is that the code generates a random sequence that is the same length as the input sequence:
antigen/GeometricSeqPhenotype.java
Line 72 in 9add838
I think that we need to make the following two changes:
GeometricSeqPhenotype.java
setsthis.nucleotideSequence
to be equal toParamters.startingSequence
.startingSequenceGenerator
, which generates a random sequence that is the same length as the input sequence.The text was updated successfully, but these errors were encountered: