Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry instrumentation #141

Closed
daniel-abramov opened this issue Mar 8, 2023 · 0 comments
Closed

Add OpenTelemetry instrumentation #141

daniel-abramov opened this issue Mar 8, 2023 · 0 comments
Assignees
Labels
T-Enhancement New feature or request

Comments

@daniel-abramov
Copy link
Contributor

daniel-abramov commented Mar 8, 2023

Relates to #50

UPD. We actually decided that we won't replace the logging in favor of telemetry. Telemetry and logging can co-exist and it's encouraged to use both. Logging has a couple of advantages: they allow us to provide more information and can be separately processed while applying log-level filtering. I.e. it's not a problem to turn on debug logs and get lots of things logged as long as the logging framework is efficient, but using debug-level logs for telemetry is not optimal and may produce large unreadable traces.

The idea is to introduce telemetry while preserving logs in the first step. But since many telemetry events duplicate info-level logs, the next step would be to adapt our logging framework so that e.g. info level events produce telemetry span events.

Thus, we would use telemetry to create and manage spans and their context, while relying upon logs for logging and for producing telemetry span events.

@daniel-abramov daniel-abramov added the T-Enhancement New feature or request label Mar 8, 2023
@daniel-abramov daniel-abramov self-assigned this Mar 8, 2023
@daniel-abramov daniel-abramov changed the title Convert regular logging into OpenTelemetry span events Add OpenTelemetry instrumentation Mar 16, 2023
daniel-abramov added a commit that referenced this issue Mar 16, 2023
daniel-abramov added a commit that referenced this issue Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant