Merge pull request #246 from matrix-org/dmr/fix-check-username-as-spam

Fix block_usernames config option

synapse_antispam/mjolnir/antispam.py

@@ -120,7 +120,9 @@ def user_may_invite(self, inviter_user_id, invitee_user_id, room_id):
 
     def check_username_for_spam(self, user_profile):
         if not self.block_usernames:
-            return True  # allowed (we aren't blocking based on usernames)
+            # /!\ NB: unlike other checks, where `True` means allowed,
+            # here `True` means "this user is a spammer".
+            return False  # allowed (we aren't blocking based on usernames)
 
         # Check whether the user ID or display name matches any of the banned
         # patterns.