Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unread notification count remains stagnant when push rules are enabled. #4091

Closed
dhaval-t-simform opened this issue Mar 4, 2024 · 1 comment

Comments

@dhaval-t-simform
Copy link

Description:
When activating the push rules using PUSH_MASTER_RULE = ".m.rule.master", the issue arises where the /sync stream fails to reflect any changes in the unread notification count.
Initially, if there are 3 unread notifications, enabling the push master rule doesn't update this count for new incoming messages i.e. we receive 3 as the unread count from the /sync stream. Subsequently, if the push rules are disabled, the unread count remains stagnant at 3. However, as new messages come in, the count incrementally increases to 4, 5, and so forth.
When the push rules are enabled, the notification count fails to update, and even upon disabling them thereafter, the count increases on the new message but have no track of previously received notification.

Steps to Reproduce:

  • Initially check the unread notification count.
  • Enable PUSH_MASTER_RULE = ".m.rule.master".
  • Now check unread count on receiving new message.
  • Disable PUSH_MASTER_RULE = ".m.rule.master".
  • Again check unread notification count on receiving new messages.

notification_count_issue
https://spec.matrix.org/unstable/client-server-api/#receiving-notifications

Expected Behavior:
Get updated notification count in the sync stream to keep track of unread count.

Actual Behavior:
Not able to receive updated notification count in the sync stream to keep track of unread count.

Environment:
matrix-js-sdk version: [29.1.0]
React version: [18.2.0]
Node.js version: [18.16.0]
Operating System: [Ubuntu 20.04]

If more information is needed, let me know I can provide.

@t3chguy
Copy link
Member

t3chguy commented Mar 5, 2024

When activating the push rules using PUSH_MASTER_RULE = ".m.rule.master", the issue arises where the /sync stream fails to reflect any changes in the unread notification count.

This would be an issue with the server, not the SDK.

@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants