Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Update Sentry reporting further #3306

Open
S7evinK opened this issue Jan 18, 2024 · 0 comments
Open

Update Sentry reporting further #3306

S7evinK opened this issue Jan 18, 2024 · 0 comments
Labels
good first issue Want to help with Dendrite? These are the issues to start with! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@S7evinK
Copy link
Contributor

S7evinK commented Jan 18, 2024

#3305 made reporting errors a bit better, but there are still places in the code where we CaptureException in go routines, possibly still sending garbage to Sentry.
For reference: https://docs.sentry.io/platforms/go/usage/concurrency/

It may also make sense to check if we even should report said errors to sentry, as e.g. we should always be able json.Unmarshal things we sent to JetStream ourselves.

@S7evinK S7evinK added good first issue Want to help with Dendrite? These are the issues to start with! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Want to help with Dendrite? These are the issues to start with! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

1 participant