-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color histogram bars #216
Color histogram bars #216
Conversation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
I've just fixed some failing tests (due to a new Matplotlib release) at #217, so worth merging or rebasing main. |
Strange. The figures in the deepcopy(fig).savefig('./baseline/name_of_test_function.png') but this generates an incorrect figures size, as it seems. Is there a correct way to save the generated test figures? As for the other failing tests, I merged the current head into this branch but am not sure why tests are failing. |
Hi @dstansby , could you give me a hint on how to properly create the figures needed for the test to make the checks pass? Would be much appreciated :) |
I think the test figures were in the right place, but just needed updating due to changes that happened between opening the PR and now. I've merged in main, and updated the figures, so lets see if the tests pass now 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for the PR 👍
@dstansby
Fixes #58
This PR expands the feature histogram widget to color the histogram bars according to the color values in the displayed layer. Currently supported:
I'm not sure how tracks/shapes layer handle features and color, but this can be added relatively easily here.
Tests
pytest --mpl
- it's probably the same issue as in this PR.