Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image rotator for Matplotlib 3.8 #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Nov 15, 2023

This also updates the generator to handle the move of gallery files.

This adds ecdf, stackplot, and stairs, and removes step. A lot of images changed with no reason, so I'm looking to see if there's a way to make the plots more reproducible.

Fixes #88

This also updates the generator to handle the move of gallery files.
@QuLogic
Copy link
Member Author

QuLogic commented Nov 15, 2023

Also, the generator doesn't include 3d and unstructured; should we add those in?

@story645
Copy link
Member

I think 3D definitely, unstructured is more 🤷‍♀️ b/c all the images look like the ones in structured

@jklymak
Copy link
Member

jklymak commented Nov 16, 2023

Do we particularly want to add ecdf? It's a convenience wrapper of a statistical method more than a plot type and it seems more confusing than helpful to have people look at a step plot and click through to ecdf, which won't do what 99.9% of people who want a step plot will want to do.

@story645
Copy link
Member

seems more confusing than helpful to have people look at a step plot and click through to ecdf,

Why would this happen? Wouldn't clicking ecdf lead to ecdf, which is a super popular statistical plot type.

@jklymak
Copy link
Member

jklymak commented Nov 16, 2023

People get confused by hist, they will definitely get confused by ecdf.

@QuLogic
Copy link
Member Author

QuLogic commented Nov 16, 2023

It does get an ecdf caption:
image

@jklymak
Copy link
Member

jklymak commented Nov 16, 2023

Sure, but you need to understand what an ecdf is to understand what you are looking at, or what the jargon means. Otherwise it looks like stair.

Conversely I would add up structured grids. People ask how to do this all the time, and advertising it would be potentially helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matplotlib.org homepage (sometimes) links to 404 step plot type
3 participants