Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust template to support PHP 8 by default (for plugins) #77

Closed
tsteur opened this issue Nov 11, 2021 · 2 comments
Closed

Adjust template to support PHP 8 by default (for plugins) #77

tsteur opened this issue Nov 11, 2021 · 2 comments

Comments

@tsteur
Copy link
Member

tsteur commented Nov 11, 2021

That's in case we keep using Travis. Then we'd need to maybe automatically add to the template PHP 8 and things like https://github.com/innocraft/plugin-LoginSaml/blob/4.x-dev/.travis.yml#L47-L56
@sgiehl
Copy link
Member

sgiehl commented Nov 11, 2021

Note: Dropping support for PHP 7.2 would actually make that a lot easier, as the additional code won't be required and everything would work again as is.

@sgiehl
Copy link
Member

sgiehl commented Jul 4, 2023

No longer needed. Tests on GitHub actions support PHP 8.

@sgiehl sgiehl closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsteur @sgiehl