Replace Piwik with Matomo #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Sep 6, 2021
|
be good indeed to not change anything in .travis.yml as we wouldn't want any extra work for that 👍 |
|
Merged. Does it mean we need to update the submodule in Matomo core? |
|
or its covered by the weekly auto update? |
|
Should be covered by the auto update. But you can also trigger the action manually if the submodule update should be needed earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There are quite some more occurrences of
Piwik, but replacing them would require to regenerate all.travis.ymlfiles in all repos. Decided not to do that by now, as that might take too much time. Guess we can think about replacing the rest, when we need to update the travis files due another required change maybe.fixes #71