Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated travis.yml does not handle minimum PHP version correctly in some cases #32

Closed
sgiehl opened this issue Jun 14, 2017 · 0 comments · Fixed by #35
Closed

Generated travis.yml does not handle minimum PHP version correctly in some cases #32

sgiehl opened this issue Jun 14, 2017 · 0 comments · Fixed by #35
Assignees

Comments

@sgiehl
Copy link
Member

sgiehl commented Jun 14, 2017

When defining 5.5.9 as minimum PHP requirement in a plugin.json, the generated travis.yml file will use 5.5 as PHP version to test against, but in the block of excluded tests, still the original value will be used

language: php

php:
  - 5.6
  - 5.5
#  - hhvm

....

matrix:
  exclude:
    # execute latest stable tests only w/ PHP 5.5
    - php: 5.5.9
      env: TEST_SUITE=PluginTests MYSQL_ADAPTER=PDO_MYSQL TEST_AGAINST_CORE=minimum_required_piwik
    # execute UI tests only w/ PHP 5.6
    - php: 5.5.9
      env: TEST_SUITE=UITests MYSQL_ADAPTER=PDO_MYSQL TEST_AGAINST_PIWIK_BRANCH=$PIWIK_TEST_TARGET

sudo: required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants