Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum required Piwik build should run UI tests and plugin tests #12

Closed
diosmosis opened this issue Oct 21, 2015 · 2 comments
Closed
Milestone

Comments

@diosmosis
Copy link
Member

Currently the minimum_required_piwik job will only execute plugin tests. In order to detect all regressions w/ older Piwiks after changes are made for newer Piwiks, the job should execute UI tests as well.

@mattab
Copy link
Member

mattab commented Oct 21, 2015

I think the reason we didn't run the UI tests for minimum version is because it is likely the UI will look different (eg. if we changed some color or so in core).

If we did this, we would likely need two sets of UI tests, one for "minimum" and one for "current"?

@diosmosis
Copy link
Member Author

I guess there should be non-screenshot UI tests (ie, angular tests) that test for specific things. Some changes for the UI for 2.15 will break previous versions' UI, but we currently can't detect those things.

@mattab mattab added this to the Backlog milestone Oct 30, 2015
@mattab mattab closed this as completed May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants