From 86d11a1a63d9021f2c2ee58c59214891c31db409 Mon Sep 17 00:00:00 2001
From: sgiehl <stefan@matomo.org>
Date: Mon, 11 Sep 2023 09:25:41 +0200
Subject: [PATCH] apply some review feedback

---
 SiteContentDetection/SpaPwa.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/SiteContentDetection/SpaPwa.php b/SiteContentDetection/SpaPwa.php
index ed639442b..9af2063aa 100644
--- a/SiteContentDetection/SpaPwa.php
+++ b/SiteContentDetection/SpaPwa.php
@@ -33,7 +33,7 @@ public static function getPriority(): int
         return 70;
     }
 
-    public function detectByContent(?string $data = null, ?array $headers = null): bool
+    public function isDetected(?string $data = null, ?array $headers = null): bool
     {
         return false;
     }
@@ -43,7 +43,7 @@ public function shouldShowInstructionTab(SiteContentDetector $detector = null):
         return true;
     }
 
-    public function renderInstructionsTab(SiteContentDetector $detector = null): string
+    public function renderInstructionsTab(SiteContentDetector $detector): string
     {
         $model = StaticContainer::get('Piwik\Plugins\TagManager\Model\Container');
         $view = new View("@TagManager/trackingSPA");