Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Label of password input field must not block focus-click on "Confirm your password to continue" dialogue #22869

Open
4 tasks done
rr-it opened this issue Dec 16, 2024 · 1 comment
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. triaged

Comments

@rr-it
Copy link
Contributor

rr-it commented Dec 16, 2024

What happened?

I click on the label which overlays an input field: Nothing happens, and the input field is not focused.

matomo-click-on-label-text.webm

What should happen?

By clicking inside an input field, the input field must be focused.

How to fix:
Set CSS pointer-events: none; for .input-field > label

Alternative fix:
Give the password input-field of this dialogue a unique id. Right now the modal-code is repeated multiple times in the DOM (maybe once for each editable user?).

https://example.org/index.php?module=UsersManager&action=index

Modal-code:

<div class="col s12 input-field">
    <input class="control_password" type="password" id="currentUserPassword" name="currentUserPassword" spellcheck="false" autocomplete="off">
    <label for="currentUserPassword" class="">Ihr aktuelles Passwort</label>
</div>

How can this be reproduced?

  1. Go somewhere were you get the "Confirm your password to continue" dialogue.
    E.g. visit https://example.org/index.php?module=UsersManager&action=index and then give super user permissions to another user.
  2. Click somewhere else to unfocus the automatically focused password field (e.g. switch to your password manager)
  3. Click directly onto the label that hovers the password field itself.

Matomo version

5.2

PHP version

No response

Server operating system

No response

What browsers are you seeing the problem on?

Firefox

Computer operating system

Gnome/Linux

Relevant log output

No response

Validations

@rr-it rr-it added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Dec 16, 2024
@des-innocraft
Copy link

Hi @rr-it , thank you for creating the issue and bringing this to our attention, that's very appreciated. We have reviewed and triaged the problem internally, and we have confirmed it is an issue. Our team will prioritize this, and we will update you on the progress here when we have an update to share. If you have any further information or questions, please feel free to add them here.

@des-innocraft des-innocraft added triaged and removed To Triage An issue awaiting triage by a Matomo core team member labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. triaged
Projects
None yet
Development

No branches or pull requests

2 participants