Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure parameter is provided in correct type #21362

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Ensure parameter is provided in correct type #21362

merged 1 commit into from
Oct 4, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 4, 2023

Description:

fixes #21345

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 4, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Oct 4, 2023
@sgiehl sgiehl marked this pull request as ready for review October 4, 2023 09:44
@sgiehl sgiehl requested a review from a team October 4, 2023 09:44
@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 4, 2023
@sgiehl sgiehl merged commit a9e3b9e into 5.x-dev Oct 4, 2023
@sgiehl sgiehl deleted the m21345 branch October 4, 2023 12:42
@tsteur
Copy link
Member

tsteur commented Oct 4, 2023

@matomo-org/core-reviewers do other plugins also need to be updated? Like Cohorts and MarketingCampaignReporting?

@sgiehl
Copy link
Member Author

sgiehl commented Oct 5, 2023

@tsteur I had pushed fixes for those plugins as well.

@tsteur
Copy link
Member

tsteur commented Oct 10, 2023

@sgiehl do we know why tests didn't pick this one up? Or if it's possible to add tests to cover such things?

@sgiehl
Copy link
Member Author

sgiehl commented Oct 10, 2023

Actually when looking at the stack trace of the error again, there might be another problem, which would not be fixed but hidden by the changes here. It seems to pass __mtm_ranking_query_others__ as idGoal, which means the ranking query seems to group some goals in an others row for some reason. We might need to investigate that again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
3 participants