core:archive exits with 1 when only warnings occur

[ghost]

Warnings during runs of core:archive will always cause it to exit with an exit code of 1, even if the task didn't encounter any errors:

Error: error or warning logs detected, exit 1

This behavior is not helpful and IMO unexpected. *nix programs usually only return a non-zero return code when the operation requested by the user failed entirely. core:archive's current behavior makes it unreasonably complicated to decide whether it failed or not; a script that reports errors to an administrator by mail would have to parse core:archive's output to make that decision.

It would be very helpful if this behavior was either removed entirely, or if it could be disabled with a flag.

[tfunq]

I would really like to have this fixed. Any estimate on when it might be fixed?

[aleho]

Doesn't --ignore-warn work to disable that behavior?

[phaitc]

@aleho I don't see that flag being available in this doc?

[aleho]

From the Docker container:

/var/www/html# ./console core:archive --help       
Description:
  Runs the CLI archiver. It is an important tool for general maintenance and to keep Piwik very fast.

Usage:
  core:archive [options]

Options:
     […]
      --ignore-warn                                                        Return 0 exit code even if there are warning logs or error logs detected in the command output.

It's a bit chaotic, because, according to the description, also ignores errors. 🤷🏼