Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using Queued Tracking when importing logs #240

Closed
tsteur opened this issue Jan 31, 2019 · 6 comments · Fixed by #274
Closed

Avoid using Queued Tracking when importing logs #240

tsteur opened this issue Jan 31, 2019 · 6 comments · Fixed by #274

Comments

@tsteur
Copy link
Member

tsteur commented Jan 31, 2019

fixes matomo-org/matomo#12340

When importing logs there is not really any benefit to use queued tracking for those requests. It might be even rather an overhead pretty much. There is eg no performance benefit because with the importer you can already import X requests at once (which is efficient).

I'd suggest to append to all tracking requests a URL parameter &queuedtracking=0 (see matomo-org/plugin-QueuedTracking#96) which avoids queued tracking. We could have an --enable-queued-tracking flag that sets the value to 1 if for some reason a user still wants to put the requests into queued tracking first.

This way you will always get accurate results whether logs were imported correctly, how many, etc. Queued tracking can otherwise not give this information.

cc @mattab

@Findus23
Copy link
Member

Semi-related:
When Queued Tracking is enabled, the warning bulk tracking returned invalid JSON is always thrown as the server always returns a gif.

@EreMaijala
Copy link
Contributor

Indeed, would be great to have this fixed. Here's a workaround that seems to do the trick for me: use the --tracker-endpoint-path=/piwik.php?queuedtracking=0 parameter with import_logs.py.

@Littlericket
Copy link

A combination of @EreMaijala argument and "--disable-bulk-tracking" works for us. We've set --recorders to 16 to get at least decent speed ...

@mattab
Copy link
Member

mattab commented Jul 13, 2020

Could we implement this fix in Matomo 4 @tsteur ?

@tsteur
Copy link
Member Author

tsteur commented Jul 13, 2020

Would generally always add the parameter and not have a flag for it.

So not do this:

We could have an --enable-queued-tracking flag that sets the value to 1 if for some reason a user still wants to put the requests into queued tracking first.

but always do this:

add to all tracking requests a URL parameter &queuedtracking=0

@mattab
Copy link
Member

mattab commented Jul 15, 2020

would always add the parameter and not have a flag for it.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants