Skip to content

Commit

Permalink
Add more tests for TableValidator
Browse files Browse the repository at this point in the history
  • Loading branch information
@sgilmore10
sgilmore10 committed Nov 1, 2023
1 parent 52bc3d8 commit c186533
Showing 1 changed file with 166 additions and 0 deletions.
166 changes: 166 additions & 0 deletions matlab/test/arrow/array/list/tTableValidator.m
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,30 +25,43 @@
methods(Test)
function Smoke(testCase)
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);
testCase.verifyInstanceOf(validator, "arrow.array.internal.list.TableValidator");
end

function TableWithZeroVariablesError(testCase)
% Verify the TableValidator constructor throws an exception
% whose identifier is "arrow:array:list:TableWithZeroVariables"
% if provided a table with zero variables.
import arrow.array.internal.list.TableValidator

fcn = @() TableValidator(table);
testCase.verifyError(fcn, "arrow:array:list:TableWithZeroVariables");
end

function VariableNamesGetter(testCase)
% Verify the VariableNames property getter returns the
% expected string array.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);
testCase.verifyEqual(validator.VariableNames, ["Number", "Letter", "Date"]);
end

function VariableNamesNoSetter(testCase)
% Verify the VariableNames property is not settable.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);
fcn = @() setfield(validator, "VariableNames", ["A", "B", "C"]);
testCase.verifyError(fcn, "MATLAB:class:SetProhibited");
end

function VariableValidatorsGetter(testCase)
% Verify the VariableValidators getter returns the expected
% arrow.array.internal.list.Validator array.

import arrow.array.internal.list.TableValidator
import arrow.array.internal.list.DatetimeValidator
import arrow.array.internal.list.ClassTypeValidator
Expand All @@ -63,6 +76,7 @@ function VariableValidatorsGetter(testCase)
end

function VariableValidatorsNoSetter(testCase)
% Verify the VariableValidators property is not settable.
import arrow.array.internal.list.TableValidator
import arrow.array.internal.list.ClassTypeValidator

Expand All @@ -73,16 +87,168 @@ function VariableValidatorsNoSetter(testCase)
end

function ClassNameGetter(testCase)
% Verify the ClassName getter returns the expected scalar
% string.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);
testCase.verifyEqual(validator.ClassName, "table");
end

function ClassNameNoSetter(testCase)
% Verify the ClassName property is not settable.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);
fcn = @() setfield(validator, "ClassName", "string");
testCase.verifyError(fcn, "MATLAB:class:SetProhibited");
end

function ValidateElementClassTypeMismatchError(testCase)
% Verify validateElement throws an exception whose identifier
% is "arrow:array:list:ClassTypeMismatch" if the input is
% not a table.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);
errorID = "arrow:array:list:ClassTypeMismatch";
fcn = @() validator.validateElement(1);
testCase.verifyError(fcn, errorID);
fcn = @() validator.validateElement(seconds(1));
testCase.verifyError(fcn, errorID);
end

function ValidateElementNumVariablesMismatchError(testCase)
% Verify validateElement throws an exception whose identifier
% is "arrow:array:list:NumVariablesMismatch" if the input table
% does not have the expected number of variables.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);
errorID = "arrow:array:list:NumVariablesMismatch";

inputTable = table(1, "A", VariableNames=["Number", "Letter"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, errorID);

inputTable = table(1, "A", datetime(2023, 10, 30, TimeZone="UTC"), seconds(1), ...
VariableNames=["Number", "Letter", "Date", "Time"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, errorID);
end

function ValidateElementVariableNamesMismatchError(testCase)
% Verify validateElement throws an exception whose identifier
% is "arrow:array:list:NumVariablesMismatch" if the input table
% does not have the expected variable names of variables.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);
errorID = "arrow:array:list:VariableNamesMismatch";

inputTable = table(1, "A", datetime(2023, 10, 31, TimeZone="UTC"), ...
VariableNames=["A", "B", "C"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, errorID);
end

function ValidateElementErrorFromFirstVariable(testCase)
% Verify validateElement throws an exception if there is an
% issue with the first variable in the input table.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);

% validator expects the second variable to be a double
inputTable = table(true, "A", datetime(2023, 10, 31, TimeZone="UTC"), ...
VariableNames=["Number", "Letter", "Date"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, "arrow:array:list:ClassTypeMismatch");

% validator expects all table variables that are not tables
% themselves to be columnar or empty
inputTable = table([1 2 3 4], "B", datetime(2023, 10, 31, TimeZone="UTC"), ...
VariableNames=["Number", "Letter", "Date"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, "arrow:array:list:NonTabularVariablesMustBeColumnar");
end

function ValidateElementErrorFromSecondVariable(testCase)
% Verify validateElement throws an exception if there is an
% issue with the second variable in the input table.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);

% validator expects the second variable to be a string
inputTable = table(2, seconds(1), datetime(2023, 10, 31, TimeZone="UTC"), ...
VariableNames=["Number", "Letter", "Date"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, "arrow:array:list:ClassTypeMismatch");

% validator expects all table variables that are not tables
% themselves to be columnar or empty
inputTable = table(2, ["A" "B"], datetime(2023, 10, 31, TimeZone="UTC"), ...
VariableNames=["Number", "Letter", "Date"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, "arrow:array:list:NonTabularVariablesMustBeColumnar");
end

function ValidateElementErrorFromThirdVariable(testCase)
% Verify validateElement throws an exception if there is an
% issue with the third variable in the input table.
import arrow.array.internal.list.TableValidator

validator = TableValidator(testCase.BaseTable);

% validator expects the third variable to be a zoned datetime
inputTable = table(2, "B", datetime(2023, 10, 31), ...
VariableNames=["Number", "Letter", "Date"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, "arrow:array:list:ExpectedZonedDatetime");

% validator expects the third variable to be datetime
inputTable = table(2, "B", uint8(1), ...
VariableNames=["Number", "Letter", "Date"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, "arrow:array:list:ClassTypeMismatch");

% validator expects all table variables that are not tables
% themselves to be columnar or empty
inputTable = table(2, "B", datetime(2023, 10, 31, TimeZone="UTC") + days(0:4), ...
VariableNames=["Number", "Letter", "Date"]);
fcn = @() validator.validateElement(inputTable);
testCase.verifyError(fcn, "arrow:array:list:NonTabularVariablesMustBeColumnar");
end

function validateElementNoThrow(testCase)
% Verify validateElement does not throw an exception if the
% input provided matches the expected schema.

import arrow.array.internal.list.TableValidator
validator = TableValidator(testCase.BaseTable);

inputTable = table(2, "B", datetime(2023, 10, 31, TimeZone="UTC"), ...
VariableNames=["Number", "Letter", "Date"]);
validator.validateElement(inputTable);

inputTable = repmat(inputTable, [10 1]);
validator.validateElement(inputTable);

inputTable = inputTable(1:0, :);
validator.validateElement(inputTable);
end

function validateElementNestedTableVariable(testCase) %#ok<MANU>
% Verify table variables that are tables themselves do not have
% to be columnar, i.e. can have more than one variable.
import arrow.array.internal.list.TableValidator

baseTable = table(1, seconds(1), table("A", false));
validator = TableValidator(baseTable);

inputTable = table([1; 2], seconds([3;4]), table(["C"; "D"], [false; false]));
validator.validateElement(inputTable);
end
end
end

0 comments on commit c186533

Please sign in to comment.