Skip to content

Commit

Permalink
Fix compilation errors.
Browse files Browse the repository at this point in the history
  • Loading branch information
kevingurney committed Dec 4, 2024
1 parent 9396088 commit 75902fe
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ RecordBatchStreamReader::RecordBatchStreamReader(
REGISTER_METHOD(RecordBatchStreamReader, getSchema);
REGISTER_METHOD(RecordBatchStreamReader, readRecordBatch);
REGISTER_METHOD(RecordBatchStreamReader, hasNextRecordBatch);
REGISTER_METHOD(RecordBatchStreamReader, readTable);
// REGISTER_METHOD(RecordBatchStreamReader, readTable);
}

libmexclass::proxy::MakeResult RecordBatchStreamReader::make(
Expand Down Expand Up @@ -90,7 +90,6 @@ void RecordBatchStreamReader::readRecordBatch(
mda::ArrayFactory factory;
const auto record_batch_proxy_id_mda = factory.createScalar(record_batch_proxy_id);
context.outputs[0] = record_batch_proxy_id_mda;
}
}

void RecordBatchStreamReader::hasNextRecordBatch(
Expand All @@ -100,8 +99,8 @@ void RecordBatchStreamReader::hasNextRecordBatch(
if (!nextRecordBatch) {
// Try to read another RecordBatch from the
// IPC Stream.
const auto maybe_record_batch = reader->Next();
if (!maybe_record_batch) {
auto maybe_record_batch = reader->Next();
if (!maybe_record_batch.ok()) {
has_next_record_batch = false;
} else {
// If we read a RecordBatch successfully,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ class RecordBatchStreamReader : public libmexclass::proxy::Proxy {

protected:
std::shared_ptr<arrow::ipc::RecordBatchStreamReader> reader;
std::shared_ptr<arrow::ipc::RecordBatchStreamReader> nextRecordBatch;
std::shared_ptr<arrow::RecordBatch> nextRecordBatch;

void getSchema(libmexclass::proxy::method::Context& context);
void readRecordBatch(libmexclass::proxy::method::Context& context);
void hasNextRecordBatch(libmexclass::proxy::method::Context& context);
void readTable(libmexclass::proxy::method::Context& context);
// void readTable(libmexclass::proxy::method::Context& context);
};

} // namespace arrow::matlab::io::ipc::proxy

0 comments on commit 75902fe

Please sign in to comment.