Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make The "Annet" Category Stricter and Improve Contrast #58

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Make The "Annet" Category Stricter and Improve Contrast #58

merged 2 commits into from
Jun 16, 2024

Conversation

AdrianAndersen
Copy link
Collaborator

Related to mathiazom/rezervo-web#138

The colors are updated to make a better contrast with the ClassPopularityMeter. I think the pinkish color for cardio classes makes more sense than the green one, as it is now more similar to both spinning and dance classes in terms of color. In my head, it makes sense that similar sort of classes (in terms of cardio vs strength) has some level of similar gradients.

Feel free to adjust colors at your leisure, but make sure to get good contrast with the PopularityMeter ✌🏻

Before

Screenshot 2024-05-16 at 23 22 56

After

Screenshot 2024-05-16 at 23 22 53

Before

Screenshot 2024-05-16 at 23 21 26

After

Screenshot 2024-05-16 at 23 20 59

@AdrianAndersen AdrianAndersen added the Feature A new feature label May 16, 2024
@AdrianAndersen AdrianAndersen requested a review from mathiazom May 16, 2024 21:43
@AdrianAndersen AdrianAndersen self-assigned this May 16, 2024
@AdrianAndersen AdrianAndersen linked an issue May 16, 2024 that may be closed by this pull request
Improve ClassPopularityMeter contrast mathiazom/rezervo-web#120
Open
@mathiazom mathiazom merged commit 1fd6c9c into main Jun 16, 2024
3 checks passed
@mathiazom mathiazom deleted the stricter-categories branch June 16, 2024 15:20
@mathiazom
Copy link
Owner

Does not sufficiently address mathiazom/rezervo-web#120, so reopening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiazom mathiazom mathiazom approved these changes

Assignees

@AdrianAndersen AdrianAndersen

Labels
Feature A new feature
Projects
rezervo
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ClassPopularityMeter contrast
2 participants
@AdrianAndersen @mathiazom