Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Edge (Chromium) #25

Open
CrescentKohana opened this issue Jun 2, 2021 · 3 comments
Open

Support for Edge (Chromium) #25

CrescentKohana opened this issue Jun 2, 2021 · 3 comments

Comments

@CrescentKohana
Copy link

CrescentKohana commented Jun 2, 2021

Current version of Game2Text doesn't work with Edge (Chromium). It should easily fixable as it's basically just Chrome. I'm guessing changing IE.HTTP from this line to MSEdgeHTM might be enough.

I'm also proposing dropping support for the Legacy Edge completely as it's not supported anymore anyway:

Additionally, we will be ending support for the legacy version of the Microsoft Edge desktop app on March 9, 2021, in favor of the new Microsoft Edge. This means that the legacy version of the desktop app will no longer receive security updates.

Though if for some reason you'd like to keep the support for the legacy version anyway, I would just change the name used in the config to legacy_edge and keep the name edge for the new Chromium version.

Tested on:

  • Edge Version 91.0.864.37 (Official build) (64-bit)
  • Windows 10 Pro 20H2 19042.985
@CrescentKohana
Copy link
Author

CrescentKohana commented Jun 3, 2021

I just noticed that it does work when the config option is set to default. The problem is just with the keyword edge.

@mathewthe2
Copy link
Owner

I'm assuming Edge is not your default browser?

@CrescentKohana
Copy link
Author

CrescentKohana commented Jun 4, 2021

It is.
Also the registry key ProgId in Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\Shell\Associations\UrlAssociations\http\UserChoice is MSEdgeHTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants