Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft66 - Use Query to Search for Questions #69

Merged
merged 15 commits into from
Sep 30, 2020
Merged

Ft66 - Use Query to Search for Questions #69

merged 15 commits into from
Sep 30, 2020

Conversation

noce2
Copy link
Contributor

@noce2 noce2 commented Sep 29, 2020

Purpose

  • Switches from a direct resource retrieval (which can result in 404s) to a query for searching for questions by title.

Does this introduce a breaking change?

[X] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
npm test
npm run e2e

What to Check

Verify that the following are valid

  • npm test
Chrome Headless 85.0.4183.121 (Linux x86_64): Executed 64 of 68 (skipped 4) SUCCESS (1.978 secs / 1.71 secs)
TOTAL: 64 SUCCESS
TOTAL: 64 SUCCESS
  • npm run e2e
[1] Executed 12 of 12 specs SUCCESS in 27 secs.
[1] Randomized with seed 71827.
[1] [23:52:35] I/launcher - 0 instance(s) of WebDriver still running
[1] [23:52:35] I/launcher - chrome #01 passed

Other Information

Copy link
Contributor

@aakano684 aakano684 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aakano684 aakano684 merged commit c7c4a6d into ft40-b Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate Question Titles Using Query
2 participants