Skip to content
This repository has been archived by the owner on Aug 13, 2021. It is now read-only.

Rename MaterialSpring to Spring #47

Open
jverkoey opened this issue Mar 29, 2017 · 2 comments
Open

Rename MaterialSpring to Spring #47

jverkoey opened this issue Mar 29, 2017 · 2 comments

Comments

@jverkoey
Copy link

No description provided.

@jverkoey jverkoey modified the milestone: v1.0.0 Mar 29, 2017
@pingpongboss
Copy link
Contributor

The reason this was named MaterialSpring is because Rebound's library already defines a Spring class. If I rename this to Spring, devs' IDEs will ask them to disambiguate. This is not a big deal, except if devs use both material-motion's Spring and rebound's Spring. In that case, they will be forced to use the full package prefix when referring to one of them (dev's choice which one).

@jverkoey
Copy link
Author

Discussed in sprint planning: it's not super likely that people will be using Rebound and Material Motion's spring in the same file, especially if we drop the Rebound dependency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants