Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial accessible object:state-changed:focused event missing from password field when unlocking screen #294

Open
joanmarie opened this issue May 13, 2024 · 4 comments

Comments

@joanmarie
Copy link

Steps to reproduce:

  1. Acquire Orca from its main branch (see notes below)
  2. Run the unstable version of Orca in a MATE session
  3. Lock the screen and unlock it

Expected results: Orca would announce the password field.

Actual results: Orca only announces a panel.

Notes:

  • The reason why Orca stable doesn't have this bug is that it listens for the focus: event. That event was deprecated over 10 years ago. I (the Orca maintainer) am no longer listening for that event; object:state-changed:focused is expected.
  • When you perform the steps to reproduce the problem, the correct event (object:state-changed:focused) is emitted, BUT it's emitted on a panel -- presumably the ancestor of the password field. The password field only emits focus: initially.
  • If you Tab away from the password field and Shift+Tab back to it, the correct object:state-changed:focused event is fired by the password field and Orca presents it.
  • This is probably a Gtk bug. See https://gitlab.gnome.org/GNOME/gtk/-/issues/454.

@cwendling: Here's another, please and thank you very much!!

@joanmarie
Copy link
Author

This appears to be fixed by https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7239. Let's hope that lands and lands soon!

@cwendling
Copy link
Member

cwendling commented May 16, 2024

I can't really get an Orca master running just yet here, but adjusting the listener from mate-desktop/caja#1778 I get:

GTK 3.24.38

[window | ] is now focused (focus:)
[panel | ] is now focused (object:state-changed:focused)
[password text | ] is now focused (focus:)

GTK 3.24.42

[window | ] is now focused (object:state-changed:focused)
[window | ] is now focused (object:state-changed:focused)
[panel | ] is now focused (object:state-changed:focused)
[password text | ] is now focused (object:state-changed:focused)
[window | ] is now focused (object:state-changed:focused)

So it looks a bit spammy good (the first even actually happens earlier, likely when locking the screen), but and might be fixed. The last event could look a bit worrying, but it seems to actually happen after unlocking (well, after having hit Return at least), so shouldn't be a problem.

So I'd say this is fixed by upgrading GTK.

@joanmarie
Copy link
Author

Cool! @cwendling: Do you happen to know where the duplicates (which, again, I'm not worried about) are coming from?

@cwendling
Copy link
Member

@joanmarie here I actually edited my post because there isn't really any duplicate, the first event seem to happen right after when locking (so I guess the black locking window gets active), and I believe the second one is either the unlock dialog or just the same window getting active again because of user interaction. Anyway, those don't seem to be duplicates I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants