Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll: Lazymap for Mixedsearch #206

Open
matchish opened this issue May 26, 2022 · 4 comments
Open

Poll: Lazymap for Mixedsearch #206

matchish opened this issue May 26, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@matchish
Copy link
Owner

Vote the post if you need this feature
@matchish matchish added the enhancement New feature or request label May 26, 2022
@m-lotze
Copy link

m-lotze commented Jul 21, 2022

Please add this. Laravel Nova has a scout integration, but it relies on ElasticSearchEngine->lazyMap(...) being implemented.

@matchish
Copy link
Owner Author

#205
@hkulekci added lazymap already. And I think for Nova have to be enough. Original scout don't have MixedSearch functionality so I don't think Nova requires lazyMap for MixedSearch. But I didn't work with Nova so can be wrong.

@m-lotze
Copy link

m-lotze commented Jul 25, 2022

My bad. Did not see it was implemented in v6. We are unfortunately stuck on elasticsearch version 7 for now. any chance you can add it in v5 also?

@matchish
Copy link
Owner Author

PR for 6x should be compatible with 5x. So if someone will create 5x branch and cherry pick #205 there it have to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matchish @m-lotze