Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hryeong66
approved these changes
Jun 29, 2024
Comment on lines
+53
to
+67
| var titleLabel: some View { | ||
| Text(meme.title) | ||
| .font(Font.Heading.large.weight(.semibold)) | ||
| .multilineTextAlignment(.center) | ||
| .foregroundColor(Color.Text.primary) | ||
| .frame(maxWidth: .infinity, alignment: .center) | ||
| } | ||
|
|
||
| var subtitleLabel: some View { | ||
| Text("출처: \(self.meme.source)") | ||
| .font(Font.Body.xsmall) | ||
| .multilineTextAlignment(.center) | ||
| .foregroundColor(Color.Icon.assistive) | ||
| } | ||
| } |
There was a problem hiding this comment.
텍스트 한줄 제한이라 lineLimit(2)로 해야할 것 같아요~!
Comment on lines
+15
to
+18
|
|
||
| public protocol Router: AnyObject { | ||
|
|
||
| var delegate: RouterDelegate? { get set } |
Comment on lines
+11
to
+14
|
|
||
| struct MemeImageView: View { | ||
|
|
||
| // MARK: - Properties |
There was a problem hiding this comment.
요거 마이페이지랑 검색에서도 쓰여서 디자인 시스템으로 빼도 괜찮을 것 같아여!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
이슈
설명
Changes 📝
Screenshot 📸
To Reviewers 🙏