Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocketServer lingers on update #115

Open
Sidiousious opened this issue Nov 17, 2024 · 1 comment
Open

WebSocketServer lingers on update #115

Sidiousious opened this issue Nov 17, 2024 · 1 comment

Comments

@Sidiousious
Copy link

When the plugin is updated, the previous websocket server continues running on the configured port. The new version on init prints error as the port is already occupied:

15:14:36.544 | ERR | [IINACT] [OverlayPlugin] WS: Failed to start: System.Net.Sockets.SocketException (10013): Access denied.
	   at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, Boolean disconnectOnFailure, String callerName)
	   at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
	   at System.Net.Sockets.Socket.Bind(EndPoint localEP)
	   at NetCoreServer.TcpServer.Start()
	   at RainbowMage.OverlayPlugin.WebSocket.ServerController.Start() in /home/runner/work/IINACT/IINACT/OverlayPlugin.Core/WebSocket/ServerController.cs:line 75
@marzent
Copy link
Owner

marzent commented Nov 26, 2024

This should not be possible, as the WebSocketServer gets properly disposed of during unload... Most likely something crashed somewhere for that to happen (a larger log excerpt also showing the unload would be interesting here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants