Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth Encode Missing Unit of Measurement #43

Open
COMVproductions opened this issue Feb 18, 2023 · 6 comments
Open

Depth Encode Missing Unit of Measurement #43

COMVproductions opened this issue Feb 18, 2023 · 6 comments

Comments

@COMVproductions
Copy link

COMVproductions commented Feb 18, 2023

Upon export, the correct depth is being set by FaceSVG based on the Sketchup model but it is missing the unit-of-measurement to identify what that depth should be read as by Shaper Origin.

  • Current export reads: identifier shaper:cutDepth='0.197'
  • Export need to read: shaper:cutDepth='0.197in'

Without this identifier, Shaper Origin reads this depth as a fraction of the workspace instead of a fraction of a specific unit.

Upon testing, when manually adding the unit-of-measurement in the SVG code the Shaper Origin reads the Encoded Depth correctly. In conclusion, it seems to be that the missing unit-of-measurement is the only item that is causing Depth Encode misreads.

@marvingreenberg
Copy link
Owner

marvingreenberg commented Feb 18, 2023 via email

@WantokMasali
Copy link

WantokMasali commented Feb 18, 2023 via email

@marvingreenberg
Copy link
Owner

Did I ever fix this?

@WantokMasali
Copy link

WantokMasali commented Aug 24, 2023 via email

@COMVproductions
Copy link
Author

As of version 3.0.2, no unit-of-measurement is assigned to the "cutDepth" parameter upon writing an SVG profile.

The program also seems to be assigning a default cut depth of 0.197 (presumably inches) and not the actual cut depth to cuts labeled as shaper:pathType='interior' and shaper:pathType='exterior'. Only shaper:pathType='hogging' changes the cut depth from the default and assigns the correct cut depth measurement; currently without a unit-of-measurement.

@marvingreenberg
Copy link
Owner

I'm a pretty terrible maintainer of this software. So, @COMVproductions I get why it only assigns cut depth to "hogging" cuts. The plugin detects hogging cuts because there is a depth difference between two faces oriented the same way. With a inside or outside cut, there isn't. But there is obviously information about the material thinkness. I'll get right on it! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants