-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depth Encode Missing Unit of Measurement #43
Comments
Thanks, should be a quick enough fix.
…On Fri, Feb 17, 2023 at 7:14 PM COMVproductions ***@***.***> wrote:
Upon export, the correct depth is being set by FaceSVG based on the
Sketchup model but it is missing the unit of measurement to identify what
that depth should be read as by Shaper Origin.
Current export reads: identifier shaper:cutDepth='0.197'
Export need to read: shaper:cutDepth='0.197in'
Without this identifier, Shaper Origin reads this as a fraction of the
workspace.
Test show when manually adding the unit of measurement in the code the
Shaper Origin reads the Encoded Depth correctly
—
Reply to this email directly, view it on GitHub
<#43>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABU5A76G7C4LE4ENR2QOYDWYAH4TANCNFSM6AAAAAAU7752FM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This may be related or may not. When using the polygon tool in sketchup and trying to export the polygon paths, facesvg appears to convert those into an arc. This is new behavior based on your recent versioning, reverting to previous versions seems to correct this behavior.
On Feb 18, 2023, at 10:23 AM, Marvin Greenberg ***@***.***> wrote:
Thanks, should be a quick enough fix.
On Fri, Feb 17, 2023 at 7:14 PM COMVproductions ***@***.***> wrote:
Upon export, the correct depth is being set by FaceSVG based on the
Sketchup model but it is missing the unit of measurement to identify what
that depth should be read as by Shaper Origin.
Current export reads: identifier shaper:cutDepth='0.197'
Export need to read: shaper:cutDepth='0.197in'
Without this identifier, Shaper Origin reads this as a fraction of the
workspace.
Test show when manually adding the unit of measurement in the code the
Shaper Origin reads the Encoded Depth correctly
—
Reply to this email directly, view it on GitHub
<#43>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABU5A76G7C4LE4ENR2QOYDWYAH4TANCNFSM6AAAAAAU7752FM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
—
Reply to this email directly, view it on GitHub<#43 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A53SEUCDWZTQQTMDCAGIOP3WYDZORANCNFSM6AAAAAAU7752FM>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Did I ever fix this? |
I will need to revisit and let you know.
From: Marvin Greenberg ***@***.***>
Sent: Thursday, August 24, 2023 5:49 AM
To: marvingreenberg/FaceSVG ***@***.***>
Cc: WantokMasali ***@***.***>; Comment ***@***.***>
Subject: Re: [marvingreenberg/FaceSVG] Depth Encode Missing Unit of Measurement (Issue #43)
Did I ever fix this?
—
Reply to this email directly, view it on GitHub<#43 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A53SEUA5OUVJZ3HLMAWMZNTXW4WTHANCNFSM6AAAAAAU7752FM>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
|
As of version 3.0.2, no unit-of-measurement is assigned to the "cutDepth" parameter upon writing an SVG profile. The program also seems to be assigning a default cut depth of 0.197 (presumably inches) and not the actual cut depth to cuts labeled as shaper:pathType='interior' and shaper:pathType='exterior'. Only shaper:pathType='hogging' changes the cut depth from the default and assigns the correct cut depth measurement; currently without a unit-of-measurement. |
I'm a pretty terrible maintainer of this software. So, @COMVproductions I get why it only assigns cut depth to "hogging" cuts. The plugin detects hogging cuts because there is a depth difference between two faces oriented the same way. With a inside or outside cut, there isn't. But there is obviously information about the material thinkness. I'll get right on it! :-) |
Upon export, the correct depth is being set by FaceSVG based on the Sketchup model but it is missing the unit-of-measurement to identify what that depth should be read as by Shaper Origin.
Without this identifier, Shaper Origin reads this depth as a fraction of the workspace instead of a fraction of a specific unit.
Upon testing, when manually adding the unit-of-measurement in the SVG code the Shaper Origin reads the Encoded Depth correctly. In conclusion, it seems to be that the missing unit-of-measurement is the only item that is causing Depth Encode misreads.
The text was updated successfully, but these errors were encountered: