Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance.mark function #28

Closed
biopsin opened this issue Jun 27, 2022 · 10 comments
Closed

performance.mark function #28

biopsin opened this issue Jun 27, 2022 · 10 comments
Labels
feature request New feature for the extension std-tech Problem caused by missing technology, interface etc.

Comments

@biopsin
Copy link

biopsin commented Jun 27, 2022

22-06-27--1656333906_scrot

Just started to happen even after updating plug to 1.14, I must hit F5 to update the page.

Pale Moon 31.1.0 - linux5.4

@martok martok added std-tech Problem caused by missing technology, interface etc. feature request New feature for the extension labels Jun 27, 2022
@Vangelis66
Copy link

Vangelis66 commented Jun 27, 2022

I must hit F5 to update the page.

Relevant upstream issue:

JustOff/github-wc-polyfill#68

Blocking manuelpuyol_turbo scripts is a workaround for me 😉 ... YMMV...

@biopsin
Copy link
Author

biopsin commented Jun 29, 2022

Seems to be resolved, can I close this?

@martok
Copy link
Owner

martok commented Jun 29, 2022

Isn't resolved for me.

Also it should work, as far as I can see. The Performance global exists and has methods on its prototype, but they can't be called for some reason. Investigating...

Different problem. hm.
Yeah, different. Closing this here and will open a new issue...

@martok martok closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2022
@biopsin
Copy link
Author

biopsin commented Jun 29, 2022

I spoke to soon, thing is if I enable webcomponents in Pale Moon (for finn.no), I dont experience the issue on github. But as webcomponents is incomplete its also disabled by default, so Im in a limbo state at this time.

Edit: nope enabling webcomponents breaks other stuff on github then this issue, sorry but please reopen.

@martok
Copy link
Owner

martok commented Jun 29, 2022

Are you currently seeing the performance.mark errors as in this report, or "parent is null"? If the latter, then that's #30 ...

@biopsin
Copy link
Author

biopsin commented Jun 30, 2022

Yes, I see it in this report. I also see the performance.mark errors while enabling webcomponents in about:config, but I dont need to refresh the page like when disabled.

@martok martok reopened this Jun 30, 2022
@martok
Copy link
Owner

martok commented Jul 1, 2022

There is clearly something weird going on, but I don't see any errors or warnings anywhere...

Can you retest with 1.15 and let me know how it goes? There might be some A/B testing going on that has me on a different feature flag...

This might actually be related to #30 - maybe some events just get misdirected. I currently have no idea how to properly fix it because I don't understand what is broken in the first place.

@biopsin
Copy link
Author

biopsin commented Jul 2, 2022

I loaded up a fresh profile and the performance.mark errors are gone, so the issue is local.
However v.1.15 resolves the extra reload one have to perform so Im closing this.
Thank you for you time!

@biopsin biopsin closed this as completed Jul 2, 2022
@martok
Copy link
Owner

martok commented Jul 2, 2022

I loaded up a fresh profile and the performance.mark errors are gone, so the issue is local.

Sounds like some A/B testing... maybe clearing local data for github on your main profile helps?

@biopsin
Copy link
Author

biopsin commented Jul 2, 2022

@martok I also suspect there are some config settings that interfere here, but Im unable to pinpoint which at present time. A fresh userprofile seems to also have mitigated some other sitebugs I noticed on the old profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature for the extension std-tech Problem caused by missing technology, interface etc.
Projects
None yet
Development

No branches or pull requests

3 participants