cli: skip formatting instructions if not required #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott2000
force-pushed
the
lazy-format-instructions
branch
from
1d07943 to
956d1ef
Compare
`tx.format_commit_summary()` can be expensive because it needs to build an IdPrefixContext now, so it's best to avoid formatting instruction messages unless they are actually required.
scott2000
force-pushed
the
lazy-format-instructions
branch
from
956d1ef to
50b375d
Compare
yuja
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested in #4046.
Checklist
If applicable:
CHANGELOG.md