Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade scm-record from v0.2.0 to v0.3.0 #3764

Merged
merged 1 commit into from
May 27, 2024
Merged

deps: upgrade scm-record from v0.2.0 to v0.3.0 #3764

merged 1 commit into from
May 27, 2024

Conversation

arxanas
Copy link
Collaborator

@arxanas arxanas commented May 26, 2024

Fixes #3357.

I'm not sure where in the changelog this should go?

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@ilyagr
Copy link
Collaborator

ilyagr commented May 27, 2024

I'm not sure where in the changelog this should go?

I'd just put it into new features. You could list the highlights and/or link to scm-record's changelog.

Update: Actually, looking at scm-record's changelog, maybe put this into Bug Fixes? Ultimately, either is fine as far as I'm concerned.

Copy link
Collaborator

@ilyagr ilyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I just checked that the diff-editor is able to start; I didn't test out the bugfixes.

@arxanas
Copy link
Collaborator Author

arxanas commented May 27, 2024

I put it under "new features" with a link to the release notes. Someone else can move it if they like. I'll note that for git-branchless changelogs/release notes, I have a "changed" section as well, which is where I would normally put something like this.

@arxanas arxanas enabled auto-merge (rebase) May 27, 2024 20:28
@arxanas arxanas merged commit a172923 into main May 27, 2024
16 checks passed
@arxanas arxanas deleted the arxanas/deps branch May 27, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Built-in diff editor (scm-record) fails in PowerShell
4 participants