Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/lib: add git.colocate to colocate repositories by default #2512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thoughtpolice
Copy link
Collaborator

@thoughtpolice thoughtpolice commented Nov 3, 2023

Summary: Closes #2507.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@thoughtpolice thoughtpolice self-assigned this Nov 3, 2023
@thoughtpolice thoughtpolice force-pushed the aseipp/push-oolmkoukrxxt branch from 601a565 to c5f105d Compare November 3, 2023 02:50
Copy link
Collaborator

@ilyagr ilyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if others have an opinion of whether this option would be useful to them.

I'm kind of on the fence, but I'm leaning towards wanting it simply because I think I'd use it. For the same reason, I'm not sure how objective I am.

cli/src/commands/git.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
cli/src/commands/init.rs Outdated Show resolved Hide resolved
@emilazy
Copy link
Collaborator

emilazy commented Jul 1, 2024

Does anyone object to merging this? I would use it.

@thoughtpolice
Copy link
Collaborator Author

Does anyone object to merging this? I would use it.

It was blocked at the time because of #2747, but that's 99% done except for now having this feature I think, so I've returned to it this morning. It mostly just needs a few tests added. (Also, this is setting the stage for making colocation the default in the future anyway, which will probably happen after the release this week.)

@thoughtpolice thoughtpolice force-pushed the aseipp/push-oolmkoukrxxt branch from c5d4e8f to 8f98635 Compare July 1, 2024 22:34
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(let me know if this becomes ready for review)

CHANGELOG.md Show resolved Hide resolved
cli/src/commands/git/init.rs Show resolved Hide resolved
@thoughtpolice thoughtpolice force-pushed the aseipp/push-oolmkoukrxxt branch 2 times, most recently from 1de2969 to b1a77a9 Compare July 4, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: config option to colocate repositories by default
4 participants