-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli/lib: add git.colocate
to colocate repositories by default
#2512
base: main
Are you sure you want to change the base?
Conversation
601a565
to
c5f105d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if others have an opinion of whether this option would be useful to them.
I'm kind of on the fence, but I'm leaning towards wanting it simply because I think I'd use it. For the same reason, I'm not sure how objective I am.
c5f105d
to
c5d4e8f
Compare
Does anyone object to merging this? I would use it. |
It was blocked at the time because of #2747, but that's 99% done except for now having this feature I think, so I've returned to it this morning. It mostly just needs a few tests added. (Also, this is setting the stage for making colocation the default in the future anyway, which will probably happen after the release this week.) |
c5d4e8f
to
8f98635
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(let me know if this becomes ready for review)
1de2969
to
b1a77a9
Compare
Closes #2507. Signed-off-by: Austin Seipp <[email protected]>
b1a77a9
to
70f3e4a
Compare
Summary: Closes #2507.
Checklist
If applicable:
CHANGELOG.md