Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Add support for italic formatting #5089

Open
zx8 opened this issue Dec 12, 2024 · 2 comments
Open

FR: Add support for italic formatting #5089

zx8 opened this issue Dec 12, 2024 · 2 comments
Labels
polish🪒🐃 Make existing features more convenient and more consistent

Comments

@zx8
Copy link

zx8 commented Dec 12, 2024

Describe the solution you'd like

Currently, we can do e.g.

[colors]
commit_id = { fg = "green", bg = "#ff1525", bold = true, underline = true }

Would it be possible to add support for italic = true as well?

@arxanas
Copy link
Collaborator

arxanas commented Dec 12, 2024

Other interesting stylistic options (pulled from https://gist.github.com/fnky/458719343aabd01cfb17a3a4f7296797) might be:

  • dim
  • inverse
  • strikethrough
  • blinking

(Not sure which of these we already support, if any? I suppose, in the meantime, you could also manually add ANSI escape codes to your template.)

@martinvonz
Copy link
Owner

Wikipedia says this about italic 1:

Not widely supported. Sometimes treated as inverse or blink.

I don't mind still adding support for it. We should probably just not use it in default templates.

Footnotes

  1. https://en.wikipedia.org/wiki/ANSI_escape_code#Select_Graphic_Rendition_parameters

@PhilipMetzger PhilipMetzger added the polish🪒🐃 Make existing features more convenient and more consistent label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish🪒🐃 Make existing features more convenient and more consistent
Projects
None yet
Development

No branches or pull requests

4 participants