Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplication of transactions with Sparebank 1 Østlandet in v0.7.1 #64

Closed
ingvarso opened this issue Jan 17, 2024 · 4 comments · Fixed by #65
Closed

Multiplication of transactions with Sparebank 1 Østlandet in v0.7.1 #64

ingvarso opened this issue Jan 17, 2024 · 4 comments · Fixed by #65

Comments

@ingvarso
Copy link
Contributor

ingvarso commented Jan 17, 2024 •
edited
Loading

In latest version v0.7.1 transactions from Sparebank 1 Østlandet are multiplied in ynab. From my first investigations it seems like the ynabber doesn't honor the "InternalTransactionId" environment variable, which is needed for sane behavior with Sparebank 1

NORDIGEN_TRANSACTION_ID=InternalTransactionId
@ingvarso
Copy link
Contributor Author

Oh... I can see there is a major rewrite of how to configure... Does it mean you need config details for each bank to set it up? I currently have it working with Sparebank 1 Østlandet, Circle K (SEB) and Morrow bank.

@ingvarso
Copy link
Contributor Author

This is my current setup:

Sparbank 1 Østlandet:

  • Need to use InternalTransactionId
NORDIGEN_BANKID=SPAREBANK_OSTLANDET_SHEDNO22
NORDIGEN_TRANSACTION_ID=InternalTransactionId

SEB Kort Bank AB (Circle K Mastercard)

  • Needs swapflow enabled
NORDIGEN_BANKID=SEB_KORT_AB_NO_SKHSFI21
YNAB_SWAPFLOW=***************

Morrow bank

  • Works out of the box
NORDIGEN_BANKID=MORROW_NDEANOKK

@martinohansen martinohansen mentioned this issue Jan 17, 2024
Merged
martinohansen added a commit that referenced this issue Jan 17, 2024
@martinohansen
fix(nordigen): bring back transaction ID option
b8323ce 
Bring back support for the user to change transaction ID. Lets give the
users the power to change stuff while we still attempt to support all
banks with specific mappers out of the box.

Fixes #64
@martinohansen
Copy link
Owner

martinohansen commented Jan 17, 2024 •
edited
Loading

Hi 👋

I'm sorry for the trouble the duplicate entries caused, I know it can be a hassle to clean up.

I reintroduced the NORDIGEN_TRANSACTION_ID config option here: #65 please test and let me know if that works for you. Its also available as a docker image with tag: pr-65

go install github.com/martinohansen/ynabber/cmd/ynabber@b8323ce

The goal is to support every bank with individual mappers but unfortunately, it's not that easy to do. If you can provide me with a full transaction payload from your banks (you can get that with debugging turned on) I can make specific mappers for you that suit your needs.

Someday we should implement a way for the user to have complete control over the mapping between bank and ynabber.

@ingvarso
Copy link
Contributor Author

Thanks! Tested the pr-65 docker image, and it seems to work without any duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(nordigen): bring back transaction ID option martinohansen/ynabber
2 participants
@martinohansen @ingvarso