Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator== fails to compile if T is void #51

Open
Crzyrndm opened this issue Nov 5, 2022 · 4 comments
Open

operator== fails to compile if T is void #51

Crzyrndm opened this issue Nov 5, 2022 · 4 comments

Comments

@Crzyrndm
Copy link

Crzyrndm commented Nov 5, 2022

See https://godbolt.org/z/MvEoq4h7E

The std::expected docs for operator== cover this with the second overload I believe (T is void. No comparison is made against the "value")
@martinmoene
Copy link
Owner

martinmoene commented Nov 5, 2022 •
edited
Loading

Ah, thanks!
I have no memory of having noted this special case.
Will see to incorporating it, soon-ish.

Added, note to self:

@Crzyrndm
Copy link
Author

Crzyrndm commented Nov 5, 2022

From the second link above

martinmoene added a commit that referenced this issue Nov 6, 2022
@martinmoene
Fix operator==() for void 'value' type (#51, thanks @Crzyrndm)
70db1b5
@martinmoene
Copy link
Owner

Add tests for operator==() with void 'value' type.

martinmoene added a commit that referenced this issue Nov 13, 2022
@martinmoene
Fix operator==() for void 'value' type (#51, thanks @Crzyrndm)
c32b0e7 
Change operator==() for non-void expected<> to align with above.
martinmoene added a commit that referenced this issue Nov 13, 2022
@martinmoene
Add test for expected<void> relational operators (#51, thanks @Crzyrndm)
938e9f7
@Crzyrndm
Copy link
Author

Crzyrndm commented Mar 21, 2023 •
edited
Loading

Just reviewing some old issues I created
This appears to be resolved in master (the godbolt example now works. Currently no release version created)

martinmoene added a commit that referenced this issue Mar 21, 2023
@martinmoene
Release 0.6.3
74f8b09 
Fixes #50, #51, #54, #55 and nonstd-lite 68, 69

martinmoene/nonstd-lite-project#68
martinmoene/nonstd-lite-project#69
martinmoene added a commit that referenced this issue Mar 21, 2023
@martinmoene
Release 0.6.3
c8ffab6 
Fixes #50, #51, #54, #55 and nonstd-lite 56, 64, 68, 69

martinmoene/nonstd-lite-project#56
martinmoene/nonstd-lite-project#64
martinmoene/nonstd-lite-project#68
martinmoene/nonstd-lite-project#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Update to proposal p0323r12 (was 7/6/5)
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinmoene @Crzyrndm