Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precise length checking in decode_slice #210

Closed
marshallpierce opened this issue Jan 1, 2023 · 8 comments · May be fixed by #227
Closed

Precise length checking in decode_slice #210

marshallpierce opened this issue Jan 1, 2023 · 8 comments · May be fixed by #227

Comments

@marshallpierce
Copy link
Owner

It would be good to have the length error only emitted when we know it to be required.
@marshallpierce marshallpierce mentioned this issue Jan 1, 2023
Merged
8 tasks
@marshallpierce marshallpierce mentioned this issue Jan 10, 2023
Closed
mina86 added a commit to mina86/rust-base64 that referenced this issue Feb 10, 2023
@mina86
decode: use exact decoded length rather than estimation
9e1d415 
Fixes: marshallpierce#210
Fixes: marshallpierce#212
@mina86 mina86 mentioned this issue Feb 10, 2023
Open
mina86 added a commit to mina86/rust-base64 that referenced this issue Feb 10, 2023
@mina86
decode: use exact decoded length rather than estimation
d29fa2b 
Fixes: marshallpierce#210
Fixes: marshallpierce#212
mina86 added a commit to mina86/rust-base64 that referenced this issue Feb 10, 2023
@mina86
decode: use exact decoded length rather than estimation
f1aa179 
Fixes: marshallpierce#210
Fixes: marshallpierce#212
mina86 added a commit to mina86/rust-base64 that referenced this issue Feb 10, 2023
@mina86
decode: use exact decoded length rather than estimation
0b82bb1 
Fixes: marshallpierce#210
Fixes: marshallpierce#212
@davidzeng0
Copy link

Any chance this gets fixed?

@marshallpierce
Copy link
Owner Author

Any chance this gets fixed?

You're welcome to propose a PR.

@davidzeng0
Copy link

What's going on with pull #227? Is it stalled? It seems like it fixes a lot of issues. Let me know if I should start fresh or continue from that pull request.

@marshallpierce
Copy link
Owner Author

I don't know the status. Presumably the author got busy with real life, etc. Small PRs are more likely to be reviewed and merged promptly since they require smaller blocks of time to review.

@mqudsi
Copy link

mqudsi commented Feb 27, 2024

Note that this is appears to be a regression. Code used to work fine with base64 0.13 now returns an incorrect OutputSliceTooSmall error under 0.21.

mqudsi added a commit to neosmart/securestore-rs that referenced this issue Feb 27, 2024
@mqudsi
Migrate away from base64 crate
03b8cf2 
The changes from 0.20 to 0.21 introduced a now long-standing regression that
resulted in an inability to safely decode to an exact-sized output buffer.

See marshallpierce/rust-base64#210
@marshallpierce
Copy link
Owner Author

Hm, that's not good. I'll see if I can find time to address this myself.

@marshallpierce marshallpierce mentioned this issue Mar 2, 2024
Merged
@marshallpierce
Copy link
Owner Author

Fix released in 0.22.0.

@mqudsi
Copy link

mqudsi commented Mar 2, 2024

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

decode: use exact decoded length rather than estimation mina86/rust-base64
3 participants
@marshallpierce @mqudsi @davidzeng0