Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PR template where immutables and constants are specified by the crafter #62

Open
0xteddybear opened this issue Dec 10, 2024 · 0 comments · May be fixed by #68
Open

Create a PR template where immutables and constants are specified by the crafter #62

0xteddybear opened this issue Dec 10, 2024 · 0 comments · May be fixed by #68
Assignees
Labels
DX improvement changes that will make crafting & reviewing spells easier

Comments

@0xteddybear
Copy link
Collaborator

Researching where a given address came from, and verifying its validity for use in a given spell has been a very time-consuming part of the review process, both in the execution of said research itself, and in the need for reviewer-crafter interaction it creates

The idea is to create a PR template with a table in which the crafter is expected to describe every hard-coded addresses, where it came from, and why it should be considered valid.

@0xteddybear 0xteddybear self-assigned this Dec 10, 2024
@0xteddybear 0xteddybear added the DX improvement changes that will make crafting & reviewing spells easier label Dec 11, 2024
@0xteddybear 0xteddybear linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX improvement changes that will make crafting & reviewing spells easier
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant