From f235816acc1383a7bf82febe804804e14542a75e Mon Sep 17 00:00:00 2001 From: Zeeshan Asghar Date: Wed, 16 Mar 2016 09:45:35 +0500 Subject: [PATCH] squid:S2974 Classes without 'public' constructors should be 'final' squid:S1488 Local Variables should not be declared and then immediately returned or thrown --- .../main/java/com/github/moduth/blockcanary/BlockCanary.java | 2 +- .../src/main/java/com/github/moduth/blockcanary/log/Block.java | 2 +- .../main/java/com/github/moduth/blockcanary/BlockCanary.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/blockcanary-android/src/main/java/com/github/moduth/blockcanary/BlockCanary.java b/blockcanary-android/src/main/java/com/github/moduth/blockcanary/BlockCanary.java index cbb2cb0..8814a79 100644 --- a/blockcanary-android/src/main/java/com/github/moduth/blockcanary/BlockCanary.java +++ b/blockcanary-android/src/main/java/com/github/moduth/blockcanary/BlockCanary.java @@ -25,7 +25,7 @@ * * @author markzhai on 2015/9/25. */ -public class BlockCanary { +public final class BlockCanary { private static final String TAG = "BlockCanary"; diff --git a/blockcanary-core/src/main/java/com/github/moduth/blockcanary/log/Block.java b/blockcanary-core/src/main/java/com/github/moduth/blockcanary/log/Block.java index 5208306..4592501 100644 --- a/blockcanary-core/src/main/java/com/github/moduth/blockcanary/log/Block.java +++ b/blockcanary-core/src/main/java/com/github/moduth/blockcanary/log/Block.java @@ -32,7 +32,7 @@ /** * @author markzhai on 15/9/27. */ -public class Block { +public final class Block { private static final String TAG = "Block"; diff --git a/blockcanary-no-op/src/main/java/com/github/moduth/blockcanary/BlockCanary.java b/blockcanary-no-op/src/main/java/com/github/moduth/blockcanary/BlockCanary.java index b5565bd..7f7cd70 100644 --- a/blockcanary-no-op/src/main/java/com/github/moduth/blockcanary/BlockCanary.java +++ b/blockcanary-no-op/src/main/java/com/github/moduth/blockcanary/BlockCanary.java @@ -18,7 +18,7 @@ /** * No-op implementation. */ -public class BlockCanary { +public final class BlockCanary { private static BlockCanary sInstance = null;