New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vs4win/Chapter04/PrimeFactorsLib/Primes.cs ugh #109

Open

DickBaker opened this issue Nov 14, 2022 · 0 comments

DickBaker commented Nov 14, 2022

[YAGNI] given spec of "largest number entered will be 1,000" you can reduce the size of PrimeNumbers array to exclude the 997 - 503 entries
[Perf] divisor cannot exceed number subject so loop can be short-circuited (e.g. with LINQ Where)
[Perf] if (number == 1) is satisfied, code should immediately return the result instead of labouring over [many] subsequent iterations

I will submit my contender FYI as PR, but imho current reference solution sucks

enjoy red-penning mine!

DickBaker mentioned this issue

PR ready for MarkJPrice too tear apart (you did say keep it coming!) #108

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment